[ 
https://issues.apache.org/jira/browse/SAMZA-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098766#comment-14098766
 ] 

Yan Fang commented on SAMZA-383:
--------------------------------

Yes, agree, my fix is complicated and not ideal. Your fix seems good. Two 
points: 1) if we do the query when loading the page, the loading speed is 2x 
slower because in backend, the site de facto queries two pages. 2) Or we can do 
the query after loading the page (that is, the page decides showing icon or not 
after the whole page is loaded), not sure if it is feasible. 

> Switch version button may link to invalid url when we add/delete pages in 
> latest version
> ----------------------------------------------------------------------------------------
>
>                 Key: SAMZA-383
>                 URL: https://issues.apache.org/jira/browse/SAMZA-383
>             Project: Samza
>          Issue Type: Bug
>          Components: docs
>            Reporter: Yan Fang
>             Fix For: 0.8.0
>
>
> Current switch button in right-up corner has bugs in the following two 
> situations:
> 1. if we add a new versioned page which only exists in the latest version but 
> not previous version, when we click the switch button, it goes to an invalid 
> url. 
> e.g. we have page
> {code}
> http://samza.incubator.apache.org/learn/documentation/latest/new.html
> {code}
> the switch button in this page will link to 
> {code}
> http://samza.incubator.apache.org/learn/documentation/0.7.0/new.html
> {code}
> which actually does not exist.
> 2. on the other hand, if we delete a versioned page in latest version, 
> whenever we click the switch button in old page, it links to an invalid link 
> too.
> e.g. we have old page
> {code}
> http://samza.incubator.apache.org/learn/documentation/0.7.0/old.html
> {code}
> The switch button in this page actually links to 
> {code}
> http://samza.incubator.apache.org/learn/documentation/latest/old.html
> {code}
> However, obviously, the link is invalid because we already delete this page.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to