[
https://issues.apache.org/jira/browse/SAMZA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Chen updated SAMZA-412:
-----------------------------
Attachment: SAMZA-412.0.patch
Adding preliminary patches. Changes made:
* Replace all instances of {{assert}} with the appropriate JUnit {{Assert}}
method.
* Reverse {{assertEquals}} arguments so that expected and actual values are
passed into the correct parameters.
RB: https://reviews.apache.org/r/25607/
I would like to make one more pass through the changes before this is committed.
> Use assertTrue, assertFalse, assertEquals, etc rather than assert
> -----------------------------------------------------------------
>
> Key: SAMZA-412
> URL: https://issues.apache.org/jira/browse/SAMZA-412
> Project: Samza
> Issue Type: Test
> Components: test
> Reporter: David Chen
> Assignee: David Chen
> Labels: newbie
> Attachments: SAMZA-412.0.patch
>
>
> I noticed that a number of tests use {{assert}} rather than JUnit's
> {{assertTrue}}, {{assertFalse}}, {{assertEquals}}, etc. methods. From looking
> at the [JUnit.Assert
> Javadoc|http://junit.sourceforge.net/javadoc/org/junit/Assert.html], it
> appears that we are currently just using the Scala {{assert}} rather than a
> JUnit method.
> We should change all uses of {{assert}} to use one of the {{JUnit.Assert}}
> methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
