[ 
https://issues.apache.org/jira/browse/SAMZA-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271552#comment-14271552
 ] 

Chris Riccomini commented on SAMZA-504:
---------------------------------------

I don't think we can really "fix" this, since the config format is pluggable. 
The checkpoint-tool just dumps the k/v pairs. It's up to the users to create a 
config file based on the config factory that they're using. If you use a 
PropertiesConfigFactory, you just have to escape spaces and equal signs in the 
key. This isn't true for other config factories.

I don't even think we can really sanity check this in PropertiesConfigFactory, 
since space is a valid delimiter according to 
[this|http://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#load(java.io.Reader)]
 doc. If we sanity check, we'd could reject other valid properties files.

> Checkpoint tool doesn't work with task names with spaces
> --------------------------------------------------------
>
>                 Key: SAMZA-504
>                 URL: https://issues.apache.org/jira/browse/SAMZA-504
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chris Riccomini
>             Fix For: 0.8.1, 0.9.0
>
>
> From [this 
> thread|http://mail-archives.apache.org/mod_mbox/incubator-samza-dev/201501.mbox/%3C962D3CAB94174A4E9B771B88A9DFE7B10F1C8B8E%40SJEXMB02.Tivo.com%3E].
> {noformat}
> I'm running the following:
> bin/checkpoint-tool.sh --config-path config/myjob.properties --new-offsets 
> /path/to/reset-offsets.properties
> The job.name property is set in myjob.properties (this is the same config I 
> use to run the job).
> {noformat}
> {noformat}
> Warning: ignoring unrecognised property: tasknames.Partition = 
> 8.systems.kafka.streams.mytopic.partitions.8=0
> which is puzzling because the line for partition 8 in the file looks like 
> this:
> tasknames.Partition 8.systems.kafka.streams.mytopic.partitions.8=0
> {noformat}
> It looks like the space in the task name is breaking things.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to