kezhenxu94 commented on a change in pull request #1114:
URL:
https://github.com/apache/incubator-seatunnel/pull/1114#discussion_r788569581
##########
File path: tools/dependencies/checkLicense.sh
##########
@@ -17,7 +17,7 @@
# limitations under the License.
#
-./mvnw dependency:copy-dependencies -DincludeScope=runtime
-DoutputDirectory=/tmp/seatunnel-dependencies
+./mvnw -pl
'!seatunnel-examples,!seatunnel-examples/seatunnel-spark-examples,!seatunnel-examples/seatunnel-flink-examples'
dependency:copy-dependencies -DincludeScope=runtime
-DoutputDirectory=/tmp/seatunnel-dependencies
Review comment:
can you try to add a plugin declaration in `seatunnel-examples` with
`skip=true`, so when people add new examples they don't need to modify this
file.
in file `seatunnel/seatunnel-examples/pom.xml`, the plugin should be
extended by all children modules
```xml
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
