yx91490 commented on a change in pull request #1117:
URL:
https://github.com/apache/incubator-seatunnel/pull/1117#discussion_r788719144
##########
File path:
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/CheckConfigUtil.java
##########
@@ -26,17 +26,14 @@
public class CheckConfigUtil {
- public static CheckResult check(Config config, String... params) {
- StringBuilder missingParams = new StringBuilder();
- for (String param : params) {
- if (!config.hasPath(param) || config.getAnyRef(param) == null) {
- missingParams.append(param).append(",");
- }
- }
+ public static CheckResult checkAllExists(Config config, String... params) {
Review comment:
since it's in common module, should we keep `check()` method and add an
`@Deprecated` annotation to keep API compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
