BenJFan commented on code in PR #1872:
URL:
https://github.com/apache/incubator-seatunnel/pull/1872#discussion_r880143979
##########
seatunnel-dist/release-docs/LICENSE:
##########
@@ -896,6 +896,7 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) transport-netty4
(org.elasticsearch.plugin:transport-netty4-client:7.5.1 -
https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) x-content
(org.elasticsearch:elasticsearch-x-content:6.3.1 -
https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) zookeeper
(org.apache.zookeeper:zookeeper:3.4.10 - no url defined)
+ (The Apache Software License, Version 2.0) spark-excel
(com.crealytics:spark-excel_2.11:0.11.1 -
https://github.com/crealytics/spark-excel)
Review Comment:
> I introduced the spark-excel tripartite package. In addition to listing
the license of spark-excel, I also need to list the licesne of the library it
depends on, right?
Right, just add license which that you add jar name in know-dependencies.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
