Hisoka-X commented on PR #2071: URL: https://github.com/apache/incubator-seatunnel/pull/2071#issuecomment-1169489043
> > This sink connector will throw exception when find not match data, the use case I can think of is to validate upstream data. However, if the main logic can be copied to the transform, the abnormal data and normal data can be separated and written into different sinks respectively. I think in this case, this idea can play a more powerful role. > > Yes, I also think that `assert` can be used in transform , even source . That is why I encapsulate assert logic in `org.apache.seatunnel.connectors.seatunnel.assertion.excecutor.AssertExecutor` . It can be used in everywhere you want. > > Nevertheless, I have discussed this in [#1912 (comment)](https://github.com/apache/incubator-seatunnel/issues/1912#issuecomment-1154842348) . The origin ISSUE creator intended to use this sink plugin to test other plugin (soure/transform ) while developing. this is the background [#1912 (comment)](https://github.com/apache/incubator-seatunnel/issues/1912#issue-1239736437) I got it, this connector are great, maybe we can add transform after this PR merged. Then please resovle conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
