Hisoka-X commented on code in PR #2356:
URL:
https://github.com/apache/incubator-seatunnel/pull/2356#discussion_r938418520
##########
seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/util/SchemaUtil.java:
##########
@@ -117,8 +120,27 @@ public static FormatDescriptor setFormat(FormatType
format, Config config) throw
return formatDescriptor;
}
- private static void getJsonSchema(Schema schema, ObjectNode json) {
- Iterator<Map.Entry<String, JsonNode>> nodeIterator = json.fields();
+ private static void getJsonSchema(Schema schema, String json) {
Review Comment:
Sorry, but I don't think this method can implement schema parsing in list
form. Although the fields in the list are processed cyclically, the returned
schema does not reflect the attributes of the list. Maybe a field can be added
for this situation: `list`, which points to the list at the outermost level of
the schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
