Hisoka-X commented on code in PR #2382: URL: https://github.com/apache/incubator-seatunnel/pull/2382#discussion_r940866919
########## seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlan.java: ########## @@ -17,38 +17,134 @@ package org.apache.seatunnel.engine.server.dag.physical; -import org.apache.seatunnel.engine.server.task.TaskGroupInfo; +import org.apache.seatunnel.engine.common.utils.NonCompletableFuture; Review Comment: I have a little doubt, why put the scheduling-related logic directly in the physical plan, why not create a new class to do this? ########## seatunnel-core/seatunnel-seatunnel-starter/src/main/bin/start-seatunnel-seatunnel.sh: ########## @@ -0,0 +1,64 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +set -eu +# resolve links - $0 may be a softlink +PRG="$0" + +while [ -h "$PRG" ] ; do + # shellcheck disable=SC2006 + ls=`ls -ld "$PRG"` + # shellcheck disable=SC2006 + link=`expr "$ls" : '.*-> \(.*\)$'` + if expr "$link" : '/.*' > /dev/null; then + PRG="$link" + else + # shellcheck disable=SC2006 + PRG=`dirname "$PRG"`/"$link" + fi +done + +PRG_DIR=`dirname "$PRG"` +APP_DIR=`cd "$PRG_DIR/.." >/dev/null; pwd` +CONF_DIR=${APP_DIR}/config +APP_JAR=${APP_DIR}/lib/seatunnel-seatunnel-starter.jar Review Comment: Use `seatunnel-seatunnel-starter.jar` as jar name, a little strange -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
