EricJoy2048 commented on code in PR #2629:
URL:
https://github.com/apache/incubator-seatunnel/pull/2629#discussion_r962142661
##########
docs/en/connector-v2/sink/OssFile.md:
##########
@@ -0,0 +1,203 @@
+# OssFile
+
+> Oss file sink connector
+
+## Description
+
+Output data to oss file system.
+
+> Tips: We made some trade-offs in order to support more file types, so we
used the HDFS protocol for internal access to OSS and this connector need some
hadoop dependencies.
+> It's only support hadoop version **2.9.X+**.
+
+## Options
+
+| name | type | required | default value
|
+|----------------------------------| ------
|---------|-----------------------------------------------------------|
+| path | string | yes | -------
|
+| bucket | string | yes | -------
|
+| access_key | string | yes | -------
|
+| access_secret | string | yes | -------
|
+| endpoint | string | yes | -------
|
+| file_name_expression | string | no | "${transactionId}"
|
+| file_format | string | no | "text"
|
+| filename_time_format | string | no | "yyyy.MM.dd"
|
+| field_delimiter | string | no | '\001'
|
+| row_delimiter | string | no | "\n"
|
+| partition_by | array | no | -
|
+| partition_dir_expression | string | no |
"\${k0}=\${v0}\/\${k1}=\${v1}\/...\/\${kn}=\${vn}\/" |
Review Comment:
Replace `"\${k0}=\${v0}\/\${k1}=\${v1}\/...\/\${kn}=\${vn}\/" ` to
`"${k0}=${v0}/${k1}=${v1}/.../${kn}=${vn}/" `
##########
docs/en/connector-v2/sink/OssFile.md:
##########
@@ -0,0 +1,203 @@
+# OssFile
+
+> Oss file sink connector
+
+## Description
+
+Output data to oss file system.
+
+> Tips: We made some trade-offs in order to support more file types, so we
used the HDFS protocol for internal access to OSS and this connector need some
hadoop dependencies.
+> It's only support hadoop version **2.9.X+**.
+
+## Options
+
+| name | type | required | default value
|
+|----------------------------------| ------
|---------|-----------------------------------------------------------|
+| path | string | yes | -------
|
+| bucket | string | yes | -------
|
+| access_key | string | yes | -------
|
+| access_secret | string | yes | -------
|
+| endpoint | string | yes | -------
|
+| file_name_expression | string | no | "${transactionId}"
|
+| file_format | string | no | "text"
|
+| filename_time_format | string | no | "yyyy.MM.dd"
|
+| field_delimiter | string | no | '\001'
|
+| row_delimiter | string | no | "\n"
|
+| partition_by | array | no | -
|
Review Comment:
`-` is the default partition key? Or `-` is seem as `-------` only mean
there is no default value?
##########
docs/en/connector-v2/sink/OssFile.md:
##########
@@ -0,0 +1,203 @@
+# OssFile
+
+> Oss file sink connector
+
+## Description
Review Comment:
Please update this document when
https://github.com/apache/incubator-seatunnel/pull/2625 merged
##########
docs/en/connector-v2/source/OssFile.md:
##########
@@ -11,15 +11,15 @@ Read data from aliyun oss file system.
## Options
Review Comment:
Please update this document when
https://github.com/apache/incubator-seatunnel/pull/2625 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
