laglangyue commented on PR #2640:
URL:
https://github.com/apache/incubator-seatunnel/pull/2640#issuecomment-1236390519
if this we must make spark image contains the driver jar，and the lib must be
spark jars.
we copy it to seatunnel plugins lib，for dm，I will run command: curl -o to
local path，and copy it to spark container.
I con`t curl it in container，because the user is root.
---Original---
From: ***@***.***>
Date: Mon, Sep 5, 2022 00:05 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/incubator-seatunnel] [Improve][e2e]copy jars
ofplugin-lib for e2e (PR #2640)
This involves the core process code, which I need to merge after testing it
locally.
I think this is useless for e2e. The jar package that the plugin depends on
should not be included in the e2e module, and the external dependency jars
added need to be put into the specified directory by the developer, which
greatly limits the packaging of the whole project. I think it is better for
developers to create a docker image that contains jdbc drivers or other jar
packages, so that it can be decoupled from the whole project and developers
only need to pay attention to the e2e tests of their own development
connectors. What do you think about it? @CalvinKirs @EricJoy2048 @hailin0
@Hisoka-X
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
