TyrantLucifer commented on code in PR #2633:
URL:
https://github.com/apache/incubator-seatunnel/pull/2633#discussion_r963008260
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/spark/SparkContainer.java:
##########
@@ -97,7 +97,8 @@ public Container.ExecResult executeSeaTunnelSparkJob(String
confFile) throws IOE
// Running IT use cases under Windows requires replacing \ with /
String conf = targetConfInContainer.replaceAll("\\\\", "/");
final List<String> command = new ArrayList<>();
- command.add(Paths.get(SEATUNNEL_HOME, "bin",
SEATUNNEL_SPARK_BIN).toString());
+ String sparkBinPath = Paths.get(SEATUNNEL_HOME, "bin",
SEATUNNEL_SPARK_BIN).toString();
+ command.add(sparkBinPath.replaceAll("\\\\", "/"));
Review Comment:
Could you please move `replaceAll` method out of `command.add()`? This will
make the process clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
