dijiekstra commented on code in PR #2614:
URL:
https://github.com/apache/incubator-seatunnel/pull/2614#discussion_r963727450
##########
seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/controller/TaskController.java:
##########
@@ -71,6 +72,12 @@ Result<InstanceSimpleInfoRes> tmpExecute(@RequestBody
@NotNull ExecuteReq req) {
return Result.success(iTaskService.tmpExecute(req));
}
+ @GetMapping("/queryInstanceLog")
+ @ApiOperation(value = "query instance log", httpMethod = "GET")
+ Result<InstanceLogRes> queryInstanceLog(@RequestParam long taskInstanceId)
{
+ return Result.success(iTaskService.queryInstanceLog(taskInstanceId));
+ }
+
@PostMapping("/kill")
@ApiOperation(value = "kill running instance", httpMethod = "POST")
Result<Void> kill(@RequestParam Long instanceId) {
Review Comment:
Use `@JSONField(serializeUsing = ToStringSerializer.class)` can avoid
precision loss when the back-end passes Long to the front-end.
And when front-end uses string data type to call back-end's api , if
backend use Long to get the param, it's still work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
