ashulin commented on code in PR #2770:
URL:
https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r975543747
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -144,4 +145,9 @@ public void testJdbcDmdbSourceAndSink() throws IOException,
InterruptedException
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws
IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash",
"-c", "mkdir -p /tmp/seatunnel/plugins/Jdbc/lib && cd
/tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
Other similar code in this PR is handled like this:
```suggestion
Container.ExecResult extraCommands =
container.execInContainer("bash", "-c", "mkdir -p
/tmp/seatunnel/plugins/Jdbc/lib && cd /tmp/seatunnel/plugins/Jdbc/lib && curl
-O " + THIRD_PARTY_PLUGINS_URL);
```
To support multiple engines, I unified the Seatunnel Home(`/tmp/seatunnel`)
without engine prefixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
