liugddx commented on code in PR #2982:
URL:
https://github.com/apache/incubator-seatunnel/pull/2982#discussion_r1003935951
##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkExecution.java:
##########
@@ -90,6 +111,33 @@ private void registerPlugin() {
pluginsJarDependencies.forEach(url ->
FlinkCommon.ADD_URL_TO_CLASSLOADER.accept(Thread.currentThread().getContextClassLoader(),
url));
- flinkEnvironment.registerPlugin(pluginsJarDependencies);
+ jarPaths.addAll(pluginsJarDependencies);
+ }
+
+ private Config registerPlugin(Config config, List<URL> jars) {
+ config = this.parseConfig(config, ConfigUtil.joinPath("env",
"pipeline", "jars"), jars);
+ return this.parseConfig(config, ConfigUtil.joinPath("env", "pipeline",
"classpaths"), jars);
Review Comment:
> Change the doc to tell user the new way add jar. Also this function should
support spark later.
Spark uses the command line,i don't think it needs changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
