FWLamb commented on code in PR #3394:
URL:
https://github.com/apache/incubator-seatunnel/pull/3394#discussion_r1020668154
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/config/CommonConfig.java:
##########
@@ -20,27 +20,62 @@
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull;
+import org.apache.seatunnel.api.configuration.Option;
+import org.apache.seatunnel.api.configuration.Options;
+
import org.apache.seatunnel.shade.com.typesafe.config.Config;
import lombok.Getter;
import lombok.ToString;
import java.io.Serializable;
+import java.util.List;
@Getter
@ToString
public class CommonConfig implements Serializable {
private static final long serialVersionUID = 239821141534421580L;
- private static final String KEY_CATALOG_NAME = "catalog_name";
- private static final String KEY_CATALOG_TYPE = "catalog_type";
- private static final String KEY_NAMESPACE = "namespace";
- private static final String KEY_TABLE = "table";
- private static final String KEY_URI = "uri";
- private static final String KEY_WAREHOUSE = "warehouse";
- private static final String KEY_CASE_SENSITIVE = "case_sensitive";
+ public static final Option<String> KEY_CATALOG_NAME =
Options.key("catalog_name")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(" the iceberg catalog name");
+
+ public static final Option<String> KEY_CATALOG_TYPE =
Options.key("catalog_type")
+ .stringType()
Review Comment:
Thank you.I will fix it.
##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/config/SourceConfig.java:
##########
@@ -32,12 +34,35 @@
public class SourceConfig extends CommonConfig {
private static final long serialVersionUID = -1965861967575264253L;
- private static final String KEY_START_SNAPSHOT_TIMESTAMP =
"start_snapshot_timestamp";
- private static final String KEY_START_SNAPSHOT_ID = "start_snapshot_id";
- private static final String KEY_END_SNAPSHOT_ID = "end_snapshot_id";
- private static final String KEY_USE_SNAPSHOT_ID = "use_snapshot_id";
- private static final String KEY_USE_SNAPSHOT_TIMESTAMP =
"use_snapshot_timestamp";
- private static final String KEY_STREAM_SCAN_STRATEGY =
"stream_scan_strategy";
+ public static final Option<Long> KEY_START_SNAPSHOT_TIMESTAMP =
Options.key("start_snapshot_timestamp")
+ .longType()
+ .noDefaultValue()
+ .withDescription(" the iceberg timestamp of starting snapshot ");
+
+ public static final Option<Long> KEY_START_SNAPSHOT_ID =
Options.key("start_snapshot_id")
+ .longType()
+ .noDefaultValue()
+ .withDescription(" the iceberg id of starting snapshot ");
+
+ public static final Option<Long> KEY_END_SNAPSHOT_ID =
Options.key("end_snapshot_id")
+ .longType()
+ .noDefaultValue()
+ .withDescription(" the iceberg id of ending snapshot ");
+
+ public static final Option<Long> KEY_USE_SNAPSHOT_ID =
Options.key("use_snapshot_id")
+ .longType()
+ .noDefaultValue()
+ .withDescription(" the iceberg used snapshot id");
+
+ public static final Option<Long> KEY_USE_SNAPSHOT_TIMESTAMP =
Options.key("use_snapshot_timestamp")
+ .longType()
+ .noDefaultValue()
+ .withDescription(" the iceberg used snapshot timestamp");
+
+ public static final Option<Long> KEY_STREAM_SCAN_STRATEGY =
Options.key("stream_scan_strategy")
+ .longType()
Review Comment:
Thank you.I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
