Hisoka-X commented on code in PR #3353:
URL:
https://github.com/apache/incubator-seatunnel/pull/3353#discussion_r1032044586
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServerStarter.java:
##########
@@ -39,6 +40,13 @@ public static HazelcastInstanceImpl
createHazelcastInstance(String clusterName)
new SeaTunnelNodeContext(seaTunnelConfig))).getOriginal();
}
+ public static HazelcastInstanceImpl createHazelcastInstance(@NonNull
SeaTunnelConfig seaTunnelConfig) {
+ return ((HazelcastInstanceProxy)
HazelcastInstanceFactory.newHazelcastInstance(
+ seaTunnelConfig.getHazelcastConfig(),
+
HazelcastInstanceFactory.createInstanceName(seaTunnelConfig.getHazelcastConfig()),
+ new SeaTunnelNodeContext(seaTunnelConfig))).getOriginal();
+ }
+
public static HazelcastInstanceImpl createHazelcastInstance() {
SeaTunnelConfig seaTunnelConfig =
ConfigProvider.locateAndGetSeaTunnelConfig();
return ((HazelcastInstanceProxy)
HazelcastInstanceFactory.newHazelcastInstance(
Review Comment:
Remove deplicate code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
