EricJoy2048 commented on code in PR #3640:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3640#discussion_r1039675210


##########
docs/en/connector-v2/sink/Maxcompute.md:
##########
@@ -0,0 +1,80 @@
+# Maxcompute
+
+> Maxcompute sink connector
+
+## Description
+
+Used to read data from Maxcompute.
+
+## Key features
+
+- [x] [batch](../../concept/connector-v2-features.md)
+- [ ] [exactly-once](../../concept/connector-v2-features.md)
+- [ ] [schema projection](../../concept/connector-v2-features.md)
+- [x] [parallelism](../../concept/connector-v2-features.md)
+
+## Options
+
+| name                    | type    | required  | default value |
+|-------------------------|---------|-----------|---------------|
+| accessId                | string  | yes       | -             |
+| accesskey               | string  | yes       | -             |
+| endpoint                | string  | yes       | -             |
+| project                 | string  | yes       | -             |
+| result_table_name       | string  | yes       | -             |

Review Comment:
   `result_table_name` is in `common-options` now. 
   
   Here is an example
   
   <img width="775" alt="image" 
src="https://user-images.githubusercontent.com/32193458/205663258-728e5865-dd79-473e-a47e-6f5a28d7e56c.png";>
   



##########
docs/en/connector-v2/sink/Maxcompute.md:
##########
@@ -0,0 +1,80 @@
+# Maxcompute
+
+> Maxcompute sink connector
+
+## Description
+
+Used to read data from Maxcompute.
+
+## Key features
+
+- [x] [batch](../../concept/connector-v2-features.md)

Review Comment:
   Sink Connector have no `Key features` named `batch` and it only have two 
`Key features`
   
   <img width="1251" alt="image" 
src="https://user-images.githubusercontent.com/32193458/205663740-18d4e63a-d172-4e48-8f54-ba1f30ce9b50.png";>
   



##########
docs/en/connector-v2/sink/Maxcompute.md:
##########
@@ -0,0 +1,80 @@
+# Maxcompute
+
+> Maxcompute sink connector
+
+## Description
+
+Used to read data from Maxcompute.
+
+## Key features
+
+- [x] [batch](../../concept/connector-v2-features.md)
+- [ ] [exactly-once](../../concept/connector-v2-features.md)
+- [ ] [schema projection](../../concept/connector-v2-features.md)
+- [x] [parallelism](../../concept/connector-v2-features.md)
+
+## Options
+
+| name                    | type    | required  | default value |
+|-------------------------|---------|-----------|---------------|
+| accessId                | string  | yes       | -             |
+| accesskey               | string  | yes       | -             |
+| endpoint                | string  | yes       | -             |
+| project                 | string  | yes       | -             |
+| result_table_name       | string  | yes       | -             |
+| partition_spec          | string  | no        | -             |
+| overwrite               | boolean | no        | false         |
+
+### accessId [string]
+
+`accessId` Your Maxcompute accessId which cloud be access from Alibaba Cloud.
+
+### accesskey [string]
+
+`accesskey` Your Maxcompute accessKey which cloud be access from Alibaba Cloud.
+
+### endpoint [string]
+
+`endpoint` Your Maxcompute endpoint start with http.
+
+### project [string]
+
+`project` Your Maxcompute project which is created in Alibaba Cloud.
+
+### result_table_name [string]

Review Comment:
   remove this option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to