hailin0 commented on code in PR #3396:
URL:
https://github.com/apache/incubator-seatunnel/pull/3396#discussion_r1045194523
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-datahub-flink-e2e/src/test/resources/datahub/fakesource_to_datahub.conf:
##########
@@ -42,16 +42,19 @@ source {
}
transform {
- sql {
- sql = "select name,age from fake"
- }
+ Filter {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ fields = ["name", "age"]
+ }
Review Comment:
remove
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-fake-flink-e2e/src/test/resources/fake/fakesource_to_console.conf:
##########
@@ -42,10 +42,13 @@ source {
}
transform {
- sql {
- sql = "select name,age from fake"
+ Filter {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ fields = ["name", "age"]
}
+
Review Comment:
remove
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-iotdb-flink-e2e/src/test/resources/iotdb/iotdb_source_to_sink.conf:
##########
@@ -54,13 +54,28 @@ source {
}
transform {
- sql {
- sql = "SELECT 'root.sink_group.device_a' AS device_name, ts, c_string,
c_boolean, c_tinyint, c_smallint, c_int, c_bigint, c_float, c_double FROM fake
WHERE device_name = 'root.source_group.device_a' UNION SELECT
'root.sink_group.device_b' AS device_name, ts, c_string, c_boolean, c_tinyint,
c_smallint, c_int, c_bigint, c_float, c_double FROM fake WHERE device_name =
'root.source_group.device_b'"
- }
+Replace {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ replace_field = "device_name"
+ pattern = "root.source_group.device_a"
+ replacement = "root.sink_group.device_a"
+ is_regex = false
+ }
+Replace {
+ source_table_name = "fake1"
+ result_table_name = "fake2"
+ replace_field = "device_name"
+ pattern = "root.source_group.device_b"
+ replacement = "root.sink_group.device_b"
+ is_regex = false
+ }
+
Review Comment:
```suggestion
Replace {
source_table_name = "fake"
result_table_name = "fake1"
replace_field = "device_name"
pattern = "root.source_group"
replacement = "root.sink_group"
is_regex = false
}
```
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/resources/jdbc/fakesource_to_jdbc.conf:
##########
@@ -42,17 +42,18 @@ source {
}
transform {
- sql {
- sql = "select name from fake"
+ Filter {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ fields = ["name"]
}
-
# If you would like to get more information about how to configure seatunnel
and see full list of transform plugins,
# please go to https://seatunnel.apache.org/docs/transform/sql
}
sink {
Jdbc {
- source_table_name = fake
+ source_table_name = fake1
Review Comment:
remove
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/resources/jdbc/fakesource_to_jdbc.conf:
##########
@@ -42,17 +42,18 @@ source {
}
transform {
- sql {
- sql = "select name from fake"
+ Filter {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ fields = ["name"]
}
Review Comment:
remove
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-assert-e2e/src/test/resources/assertion/fakesource_to_assert.conf:
##########
@@ -41,16 +41,19 @@ source {
}
transform {
- sql {
- sql = "select name,age from fake"
- }
+ Filter {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ fields = ["name", "age"]
+ }
# If you would like to get more information about how to configure seatunnel
and see full list of transform plugins,
# please go to
https://seatunnel.apache.org/docs/flink/configuration/transform-plugins/Sql
}
sink {
Assert {
+ source_table_name = "fake1"
Review Comment:
```suggestion
source_table_name = "fake1"
```
##########
seatunnel-e2e/seatunnel-transforms-v2-e2e/src/test/java/org/apache/seatunnel/e2e/transform/TestSuiteBase.java:
##########
@@ -37,7 +37,7 @@
TestCaseInvocationContextProvider.class
})
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
-@DisabledOnContainer(value = {}, type = {EngineType.FLINK, EngineType.SPARK},
disabledReason = "TODO: Transform v2 translation to spark/flink isn't
completed")
+@DisabledOnContainer(value = {}, type = {EngineType.SPARK}, disabledReason =
"TODO: Transform v2 translation to spark/flink isn't completed")
Review Comment:
```suggestion
@DisabledOnContainer(value = {}, type = {EngineType.SPARK}, disabledReason =
"TODO: Transform v2 translation to spark isn't completed")
```
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-iotdb-flink-e2e/src/test/resources/iotdb/iotdb_source_to_sink.conf:
##########
@@ -54,13 +54,28 @@ source {
}
transform {
- sql {
- sql = "SELECT 'root.sink_group.device_a' AS device_name, ts, c_string,
c_boolean, c_tinyint, c_smallint, c_int, c_bigint, c_float, c_double FROM fake
WHERE device_name = 'root.source_group.device_a' UNION SELECT
'root.sink_group.device_b' AS device_name, ts, c_string, c_boolean, c_tinyint,
c_smallint, c_int, c_bigint, c_float, c_double FROM fake WHERE device_name =
'root.source_group.device_b'"
- }
+Replace {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ replace_field = "device_name"
+ pattern = "root.source_group.device_a"
+ replacement = "root.sink_group.device_a"
+ is_regex = false
+ }
+Replace {
+ source_table_name = "fake1"
+ result_table_name = "fake2"
+ replace_field = "device_name"
+ pattern = "root.source_group.device_b"
+ replacement = "root.sink_group.device_b"
+ is_regex = false
+ }
+
}
sink {
IoTDB {
+ source_table_name = "fake2"
Review Comment:
```suggestion
source_table_name = "fake1"
```
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-datahub-flink-e2e/src/test/resources/datahub/fakesource_to_datahub.conf:
##########
@@ -42,16 +42,19 @@ source {
}
transform {
- sql {
- sql = "select name,age from fake"
- }
+ Filter {
+ source_table_name = "fake"
+ result_table_name = "fake1"
+ fields = ["name", "age"]
+ }
# If you would like to get more information about how to configure seatunnel
and see full list of transform plugins,
# please go to https://seatunnel.apache.org/docs/transform/sql
}
sink {
DataHub {
+ source_table_name = "fake1"
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
