liugddx commented on code in PR #3694:
URL:
https://github.com/apache/incubator-seatunnel/pull/3694#discussion_r1049200923
##########
seatunnel-engine/seatunnel-engine-storage/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/IMapFileStorage.java:
##########
@@ -221,7 +223,7 @@ public Set<Object> loadAllKeys() {
}
@Override
- public void destroy() {
+ public void destroy(boolean deleteAllFileFlag) {
Review Comment:
> why do you create a new method?
Sometimes I don't need to delete files, is there a better solution? Just
like jdbc closes the connection but keeps the data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
