[GitHub] [incubator-seatunnel] lightzhao commented on a diff in pull request #3989: [Bug][Connector-v2][PulsarSource]Fix pulsar option topic-pattern bug.

Tue, 31 Jan 2023 18:24:34 -0800 


lightzhao commented on code in PR #3989:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3989#discussion_r1092693953


##########
seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/PulsarSource.java:
##########
@@ -213,12 +213,14 @@ private void setPartitionDiscoverer(Config config) {
         if (StringUtils.isNotBlank(topic)) {
             this.partitionDiscoverer = new 
TopicListDiscoverer(Arrays.asList(StringUtils.split(topic, ",")));
         }
-        String topicPattern = config.getString(TOPIC_PATTERN.key());
-        if (StringUtils.isNotBlank(topicPattern)) {
-            if (this.partitionDiscoverer != null) {
-                throw new 
PulsarConnectorException(SeaTunnelAPIErrorCode.OPTION_VALIDATION_FAILED, 
String.format("The properties '%s' and '%s' is exclusive.", TOPIC.key(), 
TOPIC_PATTERN.key()));
+        if (config.hasPath(TOPIC_PATTERN.key())) {

Review Comment:
   The exclusive configuration of these two parameters has been added.
   <img width="929" alt="image" 
src="https://user-images.githubusercontent.com/40714172/215929458-88913775-5c78-48ed-a594-cb8b4e41057d.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to