dijiekstra commented on code in PR #23:
URL:
https://github.com/apache/incubator-seatunnel-web/pull/23#discussion_r1111817546
##########
seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/service/impl/UserServiceImpl.java:
##########
@@ -142,6 +145,10 @@ public UserSimpleInfoRes login(UserLoginReq req) {
if (Objects.isNull(user)) {
throw new SeatunnelException(USERNAME_PASSWORD_NO_MATCHED);
}
+
Review Comment:
Use interceptors because you need to verify that the user state is disabled
on any interface
##########
seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/service/impl/UserServiceImpl.java:
##########
@@ -78,7 +80,8 @@ public AddUserRes add(AddUserReq addReq) {
res.setId(userId);
// 3. add to role
- roleServiceImpl.addUserToRole(userId, addReq.getType().intValue());
+ // TODO waiting for optimization
Review Comment:
Why do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
