hailin0 commented on code in PR #4411:
URL:
https://github.com/apache/incubator-seatunnel/pull/4411#discussion_r1148380626
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/SingleFieldOutputTransform.java:
##########
@@ -36,6 +43,14 @@ public abstract class SingleFieldOutputTransform extends
AbstractSeaTunnelTransf
private int fieldIndex;
private SeaTunnelRowContainerGenerator rowContainerGenerator;
+ public SingleFieldOutputTransform() {
+ super();
+ }
Review Comment:
remove
```suggestion
```
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/replace/ReplaceTransform.java:
##########
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.transform.replace;
+
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.configuration.util.ConfigValidator;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.api.table.catalog.Column;
+import org.apache.seatunnel.api.table.type.BasicType;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.api.transform.SeaTunnelTransform;
+import org.apache.seatunnel.transform.common.SeaTunnelRowAccessor;
+import org.apache.seatunnel.transform.common.SingleFieldOutputTransform;
+
+import org.apache.commons.collections4.CollectionUtils;
+
+import com.google.auto.service.AutoService;
+import lombok.NonNull;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+@AutoService(SeaTunnelTransform.class)
+public class ReplaceTransform extends SingleFieldOutputTransform {
+ private ReplaceTransformConfig replaceTransformConfig;
+ private int inputFieldIndex;
+
+ public ReplaceTransform() {
+ super();
+ }
Review Comment:
as above
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/SingleFieldOutputTransform.java:
##########
@@ -17,17 +17,24 @@
package org.apache.seatunnel.transform.common;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.api.table.catalog.Column;
+import org.apache.seatunnel.api.table.catalog.TableIdentifier;
+import org.apache.seatunnel.api.table.catalog.TableSchema;
import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import lombok.NonNull;
import lombok.extern.slf4j.Slf4j;
import java.util.Arrays;
import java.util.LinkedList;
+import java.util.List;
+import java.util.stream.Collectors;
@Slf4j
-public abstract class SingleFieldOutputTransform extends
AbstractSeaTunnelTransform {
+public abstract class SingleFieldOutputTransform extends
AbstractCatalogSupportTransform {
Review Comment:
```suggestion
@NoArgsConstructor
public abstract class SingleFieldOutputTransform extends
AbstractCatalogSupportTransform {
```
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/SingleFieldOutputTransform.java:
##########
@@ -131,4 +146,72 @@ protected SeaTunnelRow transformRow(SeaTunnelRow inputRow)
{
* @return
*/
protected abstract Object getOutputFieldValue(SeaTunnelRowAccessor
inputRow);
+
+ @Override
+ protected TableSchema transformTableSchema() {
+ Column outputColumn = getOutputColumn();
+ TableSchema.Builder builder =
+ TableSchema.builder()
+
.primaryKey(inputCatalogTable.getTableSchema().getPrimaryKey())
+
.constraintKey(inputCatalogTable.getTableSchema().getConstraintKeys());
+ List<Column> copyInputColumns =
+ inputCatalogTable.getTableSchema().getColumns().stream()
+ .map(Column::copy)
+ .collect(Collectors.toList());
+
+ int addFieldCount = 0;
+ for (int j = 0; j < copyInputColumns.size(); j++) {
+ if
(copyInputColumns.get(j).getName().equals(outputColumn.getName())) {
+ copyInputColumns.set(j, outputColumn);
+ this.fieldIndex = j;
+ } else {
+ addFieldCount++;
+ copyInputColumns.add(outputColumn);
+ }
+ }
Review Comment:
reference this pr
https://github.com/apache/incubator-seatunnel/pull/4404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
