[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #4111: [Feature][Json-format] support read format for pulsar

Wed, 12 Apr 2023 01:26:19 -0700 


laglangyue commented on code in PR #4111:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4111#discussion_r1163796538


##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -137,7 +141,7 @@ public void deserialize(byte[] message, 
Collector<SeaTunnelRow> out) {
             }
             throw new SeaTunnelJsonFormatException(
                     CommonErrorCode.JSON_OPERATION_FAILED,
-                    format("Null data value \"%s\" Cannot send downstream", 
new String(message)));
+                    format("Null data value \"%s\" Cannot send downstream", 
jsonNode.asText()));

Review Comment:
   
![image](https://user-images.githubusercontent.com/35491928/231398087-f90277b7-96d9-4fcc-8249-abc9406d51ec.png)
   I fix this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to