hailin0 commented on code in PR #4626:
URL:
https://github.com/apache/incubator-seatunnel/pull/4626#discussion_r1173374939
##########
seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/java/org/apache/seatunnel/example/spark/v2/SeaTunnelApiExample.java:
##########
@@ -26,7 +26,7 @@ public class SeaTunnelApiExample {
public static void main(String[] args)
throws FileNotFoundException, URISyntaxException, CommandException
{
- String configurePath = args.length > 0 ? args[0] :
"/examples/spark.batch.conf";
+ String configurePath = args.length > 0 ? args[0] :
"/examples/fake_to_console.conf";
Review Comment:
revert
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMySqlDialectFactory.java:
##########
@@ -0,0 +1,22 @@
+package
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.oceanbase;
+
+import java.util.Optional;
+import com.google.auto.service.AutoService;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialect;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.JdbcDialectFactory;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.mysql.MysqlDialect;
+
+@AutoService(JdbcDialectFactory.class)
+public class OceanBaseMySqlDialectFactory implements JdbcDialectFactory {
+ @Override
+ public boolean acceptsURL(String url, Optional<String> driverTye) {
+ return url.startsWith("jdbc:oceanbase:")
+ && driverTye.isPresent()
+ && driverTye.get().equalsIgnoreCase("mysql");
Review Comment:
add example into docs
##########
seatunnel-connectors-v2/connector-jdbc/pom.xml:
##########
@@ -144,7 +151,10 @@
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
</dependency>
-
+ <dependency>
Review Comment:
add this drive intoļ¼
https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml#L558
https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/src/main/assembly/assembly-bin-ci.xml#L195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
