TyrantLucifer commented on code in PR #5045:
URL: https://github.com/apache/seatunnel/pull/5045#discussion_r1264822814
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/commit/FileCommitInfo.java:
##########
@@ -34,7 +34,7 @@ public class FileCommitInfo implements Serializable {
*
* <p>V is the target file path of the data file.
*/
- private final Map<String, String> needMoveFiles;
Review Comment:
The same as above.
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/commit/FileSinkAggregatedCommitter.java:
##########
@@ -44,7 +44,7 @@ public List<FileAggregatedCommitInfo> commit(
aggregatedCommitInfos.forEach(
aggregatedCommitInfo -> {
try {
- for (Map.Entry<String, Map<String, String>> entry :
Review Comment:
The same as above.
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/state/FileSinkState.java:
##########
@@ -21,16 +21,16 @@
import lombok.Data;
import java.io.Serializable;
+import java.util.LinkedHashMap;
import java.util.List;
-import java.util.Map;
@Data
@AllArgsConstructor
public class FileSinkState implements Serializable {
private final String transactionId;
private final String uuidPrefix;
private final Long checkpointId;
- private final Map<String, String> needMoveFiles;
Review Comment:
The same as above.
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/commit/FileAggregatedCommitInfo.java:
##########
@@ -34,7 +34,7 @@ public class FileAggregatedCommitInfo implements Serializable
{
*
* <p>V is the target file path of the data file.
*/
- private final Map<String, Map<String, String>> transactionMap;
Review Comment:
Why change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
