liugddx commented on code in PR #5097:
URL: https://github.com/apache/seatunnel/pull/5097#discussion_r1267912054
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialectLoader.java:
##########
@@ -46,6 +48,8 @@ private JdbcDialectLoader() {}
* @return The loaded dialect.
*/
public static JdbcDialect load(String url, String compatibleMode) {
+ Preconditions.checkNotNull(
+ url, "Miss <Source> Jdbc config url ! Please check the config
file.");
Review Comment:
Why check whether the parameter exists here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
