ic4y commented on code in PR #5450:
URL: https://github.com/apache/seatunnel/pull/5450#discussion_r1325499624
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlan.java:
##########
@@ -81,6 +78,8 @@ public class PhysicalPlan {
/** Whether we make the job end when pipeline turn to end state. */
private boolean makeJobEndWhenPipelineEnded = true;
Review Comment:
delete it
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlan.java:
##########
@@ -141,124 +140,57 @@ public void addPipelineEndCallback(SubPlan subPlan) {
try {
if
(PipelineStatus.CANCELED.equals(pipelineState.getPipelineStatus())) {
canceledPipelineNum.incrementAndGet();
- if (makeJobEndWhenPipelineEnded) {
- LOGGER.info(
- String.format(
- "cancel job %s because
makeJobEndWhenPipelineEnded is true",
- jobFullName));
- cancelJob();
- }
} else if (PipelineStatus.FAILED.equals(
pipelineState.getPipelineStatus())) {
failedPipelineNum.incrementAndGet();
errorBySubPlan.compareAndSet(null,
pipelineState.getThrowableMsg());
if (makeJobEndWhenPipelineEnded) {
Review Comment:
remove this if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
