Re: [PR] Support multi-table sink feature for influxdb [seatunnel]

Wed, 21 Feb 2024 01:33:39 -0800 


531651225 commented on code in PR #6278:
URL: https://github.com/apache/seatunnel/pull/6278#discussion_r1497179237


##########
seatunnel-connectors-v2/connector-influxdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/influxdb/sink/InfluxDBSinkFactory.java:
##########
@@ -46,7 +56,7 @@ public String factoryIdentifier() {
     @Override
     public OptionRule optionRule() {
         return OptionRule.builder()
-                .required(URL, DATABASES, KEY_MEASUREMENT)

Review Comment:
   > please move `KEY_MEASUREMENT` to optional
   Writing to config for a single table requires configuring KEY-MEASURE, but 
not for multi table writing. 
   Reference kudu MultiTableSinkWriter
   
![image](https://github.com/apache/seatunnel/assets/33744252/db44860f-7b8e-48d1-9e8a-3bf11c71b39e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to