xiaochen-zhou commented on code in PR #6480:
URL: https://github.com/apache/seatunnel/pull/6480#discussion_r1519581686
##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/source/StarRocksSourceReader.java:
##########
@@ -87,26 +94,46 @@ public void handleNoMoreSplits() {
}
private void read(StarRocksSourceSplit split, Collector<SeaTunnelRow>
output) {
- StarRocksBeReadClient client =
- new StarRocksBeReadClient(split.getPartition(), sourceConfig,
seaTunnelRowType);
+
+ QueryPartition partition = split.getPartition();
+ String beAddress = partition.getBeAddress();
+ StarRocksBeReadClient client = null;
+ if (clientsPools.containsKey(beAddress)) {
+ client = clientsPools.get(beAddress);
+ } else {
+ client = new StarRocksBeReadClient(beAddress, sourceConfig);
+ clientsPools.put(beAddress, client);
+ }
// open scanner to be
- client.openScanner();
+ client.openScanner(partition, seaTunnelRowType);
while (client.hasNext()) {
SeaTunnelRow seaTunnelRow = client.getNext();
output.collect(seaTunnelRow);
}
- // close client to be
- if (client != null) {
- client.close();
- }
}
@Override
- public void open() throws Exception {}
+ public void open() throws Exception {
+ clientsPools = new HashMap<>();
+ }
@Override
public void close() throws IOException {
- // nothing to do
+ if (!clientsPools.isEmpty()) {
+ clientsPools
+ .values()
+ .forEach(
+ client -> {
+ if (client != null) {
+ try {
+ client.close();
+ } catch (StarRocksConnectorException e) {
+ throw new StarRocksConnectorException(
+ CLOSE_BE_READER_FAILED, e);
Review Comment:
done, please recheck at your convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
