Hisoka-X commented on code in PR #6685:
URL: https://github.com/apache/seatunnel/pull/6685#discussion_r1561937652
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java:
##########
@@ -171,6 +171,9 @@ public void pollNext(Collector<SeaTunnelRow> output) throws
Exception {
&&
record.offset()
>=
sourceSplit
.getEndOffset()) {
+ // signal to the
source that we have
Review Comment:
Thanks @SbloodyS for create this PR. Could you explain to us the purpose of
move `context.signalNoMoreElement();` to here? And why this change can fix
kafka source can not consumer all history data when use batch mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
