dailai commented on code in PR #6757:
URL: https://github.com/apache/seatunnel/pull/6757#discussion_r1593500300
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLType.java:
##########
@@ -177,12 +177,26 @@ public SeaTunnelDataType<?> getExpressionType(Expression
expression) {
SeaTunnelDataType<?> leftType =
getExpressionType(binaryExpression.getLeftExpression());
SeaTunnelDataType<?> rightType =
getExpressionType(binaryExpression.getRightExpression());
- if (leftType.getSqlType() == SqlType.INT && rightType.getSqlType()
== SqlType.INT) {
+ if ((leftType.getSqlType() == SqlType.TINYINT
Review Comment:
Could you add some test case for this to cover all the logical?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
