EricJoy2048 commented on code in PR #6808:
URL: https://github.com/apache/seatunnel/pull/6808#discussion_r1595322576
##########
seatunnel-connectors-v2/connector-influxdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/influxdb/source/InfluxdbSourceReader.java:
##########
@@ -151,4 +171,49 @@ private void read(InfluxDBSourceSplit split,
Collector<SeaTunnelRow> output) {
}
}
}
+
+ private void readByChunkSize(InfluxDBSourceSplit split,
Collector<SeaTunnelRow> output) {
+ influxdb.query(
+ new Query(split.getQuery(), config.getDatabase()),
Review Comment:
> But merely changing this method to a synchronous one is not enough, as it
occupies the lock in the pollNext method.
It is normal to occupy a lock, and we must ensure that the
lock(`output.getCheckpointLock()`) cannot be released until a split read is
completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
