This is an automated email from the ASF dual-hosted git repository.

wuchunfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 84480f0fa9 [Hotfix][Zeta] Fix okhttp connection leak in event reporter 
(#6945)
84480f0fa9 is described below

commit 84480f0fa96ad1b584aa6035b2271377ff50cc13
Author: hailin0 <[email protected]>
AuthorDate: Wed Jun 5 18:04:45 2024 +0800

    [Hotfix][Zeta] Fix okhttp connection leak in event reporter (#6945)
---
 .../engine/server/event/JobEventHttpReportHandler.java        | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git 
a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandler.java
 
b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandler.java
index fab3201e5e..1182c72673 100644
--- 
a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandler.java
+++ 
b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandler.java
@@ -33,6 +33,7 @@ import com.squareup.okhttp.OkHttpClient;
 import com.squareup.okhttp.Request;
 import com.squareup.okhttp.RequestBody;
 import com.squareup.okhttp.Response;
+import com.squareup.okhttp.ResponseBody;
 import lombok.extern.slf4j.Slf4j;
 
 import java.io.IOException;
@@ -130,10 +131,12 @@ public class JobEventHttpReportHandler implements 
EventHandler {
                         .post(RequestBody.create(httpMediaType, events));
         httpHeaders.forEach(requestBuilder::header);
         Response response = 
httpClient.newCall(requestBuilder.build()).execute();
-        if (response.isSuccessful()) {
-            committedEventIndex += resultSet.readCount();
-        } else {
-            log.error("Failed to request http server: {}", response);
+        try (ResponseBody closeable = response.body()) {
+            if (response.isSuccessful()) {
+                committedEventIndex += resultSet.readCount();
+            } else {
+                log.error("Failed to request http server: {}", response);
+            }
         }
     }
 

Reply via email to