hailin0 commented on code in PR #7131:
URL: https://github.com/apache/seatunnel/pull/7131#discussion_r1668341586
##########
seatunnel-dist/src/test/java/org/apache/seatunnel/api/connector/ConnectorSpecificationCheckTest.java:
##########
@@ -148,7 +151,31 @@ public void
testAllConnectorImplementFactoryWithUpToDateMethod() throws ClassNot
"Please remove `getConsumedType` method in " +
sinkClass.getSimpleName());
log.info(
"Check sink connector {} successfully",
factory.getClass().getSimpleName());
+
+ checkSupportMultiTableSink(sinkClass);
}
}
}
+
+ private void checkSupportMultiTableSink(Class<? extends SeaTunnelSink>
sinkClass) {
+ if (!SupportMultiTableSink.class.isAssignableFrom(sinkClass)) {
+ return;
+ }
+
+ // Validate the `createWriter` method return type
+ Optional<Method> createWriter =
+ ReflectionUtils.getDeclaredMethod(
+ sinkClass, "createWriter", SinkWriter.Context.class);
Review Comment:
Not check `restoreWriter()`、`createAggregatedCommitter()`
@Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
