Hisoka-X commented on code in PR #7273:
URL: https://github.com/apache/seatunnel/pull/7273#discussion_r1722664368
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java:
##########
@@ -58,8 +61,7 @@ public void run() {
task.accept(consumer);
}
} catch (Exception e) {
- throw new KafkaConnectorException(
- KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR,
e);
Review Comment:
> To obtain the result of the thread execution exception, Future or callback
is required. This has a great impact on the current KafkaConsumerThread code
structure transformation.
It's hard but right way. We need do this.
> consumer.commitSync is triggered at checkpoint, so even if an exception is
captured, the task may not exit abnormally.
The checkpoint error will let job failed normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
