Hisoka-X commented on code in PR #6408:
URL: https://github.com/apache/seatunnel/pull/6408#discussion_r1732223384
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_group_offset_to_console_with_commit_offset.conf:
##########
@@ -63,11 +66,11 @@ sink {
{
rule_type = MIN
- rule_value = 100
+ rule_value = 0
},
{
rule_type = MAX
- rule_value = 149
+ rule_value = 99
Review Comment:
Any reason for change test case config?
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java:
##########
@@ -66,10 +77,28 @@ public List<CatalogTable> getProducedCatalogTables() {
@Override
public SourceReader<SeaTunnelRow, KafkaSourceSplit> createReader(
SourceReader.Context readerContext) {
+
+ BlockingQueue<RecordsWithSplitIds<ConsumerRecord<byte[], byte[]>>>
elementsQueue =
+ new LinkedBlockingQueue<>();
+
+ Supplier<KafkaPartitionSplitReader> kafkaPartitionSplitReaderSupplier =
+ () -> new KafkaPartitionSplitReader(kafkaSourceConfig,
readerContext);
+
+ KafkaSourceFetcherManager kafkaSourceFetcherManager =
+ new KafkaSourceFetcherManager(
+ elementsQueue, kafkaPartitionSplitReaderSupplier::get);
+ KafkaRecordEmitter kafkaRecordEmitter =
+ new KafkaRecordEmitter(
+ kafkaSourceConfig.getMapMetadata(),
+ kafkaSourceConfig.getMessageFormatErrorHandleWay());
Review Comment:
How about move these part into `KafkaSourceReader` constructor?
##########
seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/reader/fetcher/SplitFetcher.java:
##########
@@ -234,4 +234,19 @@ private void addTaskUnsafe(SplitFetcherTask task) {
taskQueue.add(task);
nonEmpty.signal();
}
+
+ public void enqueueTask(SplitFetcherTask task) {
Review Comment:
why not direct use
https://github.com/apache/seatunnel/blob/c6f627fa38d29f83bccb3e1fb86e8962b64dad4e/seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/reader/fetcher/SplitFetcher.java#L108
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
