dailai commented on code in PR #7728:
URL: https://github.com/apache/seatunnel/pull/7728#discussion_r1774363133
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/config/PaimonSinkConfig.java:
##########
@@ -77,5 +79,12 @@ public PaimonSinkConfig(ReadonlyConfig readonlyConfig) {
this.primaryKeys = stringToList(readonlyConfig.get(PRIMARY_KEYS), ",");
this.partitionKeys = stringToList(readonlyConfig.get(PARTITION_KEYS),
",");
this.writeProps = readonlyConfig.get(WRITE_PROPS);
+ checkConfig();
+ }
+
+ private void checkConfig() {
+ if (this.primaryKeys.isEmpty() &&
"-1".equals(this.writeProps.get("bucket"))) {
Review Comment:
There's something wrong with this, because if you created the table manually
instead of automatically, there's no default value for writeProps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
