hailin0 commented on code in PR #8305:
URL: https://github.com/apache/seatunnel/pull/8305#discussion_r1892042406
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SinkReplaceNameConstant.java:
##########
@@ -26,4 +26,6 @@ public final class SinkReplaceNameConstant {
public static final String REPLACE_SCHEMA_NAME_KEY = "${schema_name}";
public static final String REPLACE_DATABASE_NAME_KEY = "${database_name}";
+
+ public static final String REPLACE_TARGET_TABLE_NAME_KEY =
"${target_table}";
Review Comment:
Why change this?
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java:
##########
@@ -152,18 +154,37 @@ public interface JdbcOptions {
.defaultValue(true)
.withDescription(
"is the primary key updated when performing an
update operation");
+
+ Option<JdbcSinkConfig.WriteMode> WRITE_MODE =
+ Options.key("write_mode")
+ .enumType(JdbcSinkConfig.WriteMode.class)
+ .defaultValue(JdbcSinkConfig.WriteMode.SQL)
+ .withDescription("write mode:
SQL/COPY_SQL/MERGE/COPY_MERGE");
Review Comment:
```suggestion
.withDescription("write mode:
SQL/COPY/COPY_SQL/MERGE/COPY_MERGE");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
