hawk9821 commented on code in PR #8736:
URL: https://github.com/apache/seatunnel/pull/8736#discussion_r1957728435
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -212,19 +212,19 @@ private static VectorSchemaRoot buildVectorSchemaRoot(
((VarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMicroVector) {
- ((TimeStampMicroVector) vector).setSafe(i,
epochMilli * 1000);
+ ((TimeStampMicroVector) vector).setSafe(i,
testEpochMilli);
Review Comment:
```suggestion
((TimeStampMicroVector) vector).setSafe(i,
epochMilli * 1000);
```
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -84,13 +85,18 @@ public class ArrowToSeatunnelRowReaderTest {
private static RootAllocator rootAllocator;
private static final List<SeaTunnelDataTypeHolder> seaTunnelDataTypeHolder
= new ArrayList<>();
+ // 2025-02-15 04:21:23
+ private static long testEpochMilli = 1739564483396L;
/**
* LocalDateTime.now() is timestamped with a precision of nanoseconds on
linux and milliseconds
* on windows The test case uses TimeStampMicroVector to test the
timestamp, thus truncating the
* timestamp accuracy to ChronoUnit.MILLIS
*/
private static final LocalDateTime localDateTime =
Review Comment:
```suggestion
private static final LocalDateTime localDateTime =
LocalDateTime.parse(
"2025-02-15 02:21:23",
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"));
```
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -212,19 +212,19 @@ private static VectorSchemaRoot buildVectorSchemaRoot(
((VarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMicroVector) {
- ((TimeStampMicroVector) vector).setSafe(i,
epochMilli * 1000);
+ ((TimeStampMicroVector) vector).setSafe(i,
testEpochMilli);
} else if (vector instanceof VarBinaryVector) {
((VarBinaryVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof LargeVarCharVector) {
((LargeVarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMilliTZVector) {
- ((TimeStampMilliTZVector) vector).setSafe(i,
epochMilli);
+ ((TimeStampMilliTZVector) vector).setSafe(i,
testEpochMilli);
Review Comment:
```suggestion
((TimeStampMilliTZVector) vector).setSafe(i,
epochMilli);
```
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -212,19 +212,19 @@ private static VectorSchemaRoot buildVectorSchemaRoot(
((VarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMicroVector) {
- ((TimeStampMicroVector) vector).setSafe(i,
epochMilli * 1000);
+ ((TimeStampMicroVector) vector).setSafe(i,
testEpochMilli);
} else if (vector instanceof VarBinaryVector) {
((VarBinaryVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof LargeVarCharVector) {
((LargeVarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMilliTZVector) {
- ((TimeStampMilliTZVector) vector).setSafe(i,
epochMilli);
+ ((TimeStampMilliTZVector) vector).setSafe(i,
testEpochMilli);
} else if (vector instanceof TimeMicroVector) {
- ((TimeMicroVector) vector).setSafe(i, epochMilli);
+ ((TimeMicroVector) vector).setSafe(i,
testEpochMilli);
Review Comment:
ditto
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -212,19 +212,19 @@ private static VectorSchemaRoot buildVectorSchemaRoot(
((VarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMicroVector) {
- ((TimeStampMicroVector) vector).setSafe(i,
epochMilli * 1000);
+ ((TimeStampMicroVector) vector).setSafe(i,
testEpochMilli);
} else if (vector instanceof VarBinaryVector) {
((VarBinaryVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof LargeVarCharVector) {
((LargeVarCharVector) vector)
.setSafe(i,
(stringValue).getBytes(StandardCharsets.UTF_8));
} else if (vector instanceof TimeStampMilliTZVector) {
- ((TimeStampMilliTZVector) vector).setSafe(i,
epochMilli);
+ ((TimeStampMilliTZVector) vector).setSafe(i,
testEpochMilli);
} else if (vector instanceof TimeMicroVector) {
- ((TimeMicroVector) vector).setSafe(i, epochMilli);
+ ((TimeMicroVector) vector).setSafe(i,
testEpochMilli);
} else if (vector instanceof DateMilliVector) {
- ((DateMilliVector) vector).setSafe(i, epochMilli);
+ ((DateMilliVector) vector).setSafe(i,
testEpochMilli);
Review Comment:
ditto
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -172,13 +178,7 @@ private static VectorSchemaRoot buildVectorSchemaRoot(
}
// allocate storage
vectors.forEach(FieldVector::allocateNew);
Review Comment:
```suggestion
vectors.forEach(FieldVector::allocateNew);
long epochMilli =
localDateTime.atZone(zoneId).toInstant().toEpochMilli();
```
##########
seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/source/arrow/ArrowToSeatunnelRowReaderTest.java:
##########
@@ -257,7 +257,7 @@ private static VectorSchemaRoot buildVectorSchemaRoot(
if ("array2".equals(name)) {
List<LocalDateTime> dateTimeList = new
ArrayList<>();
for (int j = 0; j < 5; j++) {
-
writer.writeTimeStampMilliTZ(epochMilli);
+
writer.writeTimeStampMilliTZ(testEpochMilli);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
