This is an automated email from the ASF dual-hosted git repository.

wanghailin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new d66d9dc9ce [Improve][Connector-V2] Improve orc read error message 
(#8751)
d66d9dc9ce is described below

commit d66d9dc9ce9b5d447d08df97df44b6dae734ddd5
Author: Jia Fan <[email protected]>
AuthorDate: Mon Feb 17 20:27:38 2025 +0800

    [Improve][Connector-V2] Improve orc read error message (#8751)
---
 .../seatunnel/file/source/reader/OrcReadStrategy.java       |  2 +-
 .../seatunnel/file/writer/OrcReadStrategyTest.java          | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git 
a/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java
 
b/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java
index 77b02ab03a..b1b46b0aca 100644
--- 
a/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java
+++ 
b/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java
@@ -188,7 +188,7 @@ public class OrcReadStrategy extends AbstractReadStrategy {
         } catch (IOException e) {
             String errorMsg = String.format("Create orc reader for this file 
[%s] failed", path);
             throw new FileConnectorException(
-                    CommonErrorCodeDeprecated.READER_OPERATION_FAILED, 
errorMsg);
+                    CommonErrorCodeDeprecated.READER_OPERATION_FAILED, 
errorMsg, e);
         }
     }
 
diff --git 
a/seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/OrcReadStrategyTest.java
 
b/seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/OrcReadStrategyTest.java
index 673f0cac21..7d43a0cc51 100644
--- 
a/seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/OrcReadStrategyTest.java
+++ 
b/seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/OrcReadStrategyTest.java
@@ -32,6 +32,7 @@ import org.junit.jupiter.api.Test;
 import lombok.extern.slf4j.Slf4j;
 
 import java.io.File;
+import java.io.FileNotFoundException;
 import java.net.URL;
 import java.nio.file.Paths;
 import java.util.ArrayList;
@@ -63,6 +64,18 @@ public class OrcReadStrategyTest {
         }
     }
 
+    @Test
+    public void testReadNotExistedFile() throws Exception {
+        OrcReadStrategy orcReadStrategy = new OrcReadStrategy();
+        LocalConf localConf = new LocalConf(FS_DEFAULT_NAME_DEFAULT);
+        orcReadStrategy.init(localConf);
+        Exception exception =
+                Assertions.assertThrows(
+                        Exception.class,
+                        () -> 
orcReadStrategy.getSeaTunnelRowTypeInfo("not_existed_file.orc"));
+        Assertions.assertInstanceOf(FileNotFoundException.class, 
exception.getCause());
+    }
+
     @Test
     public void testOrcReadProjection() throws Exception {
         URL orcFile = OrcReadStrategyTest.class.getResource("/test.orc");

Reply via email to