corgy-w commented on code in PR #8869:
URL: https://github.com/apache/seatunnel/pull/8869#discussion_r1974865051
##########
seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/sqlserver/SqlServerCatalogTest.java:
##########
@@ -69,9 +69,9 @@ static void before() {
sqlServerCatalog = new SqlServerCatalog("sqlserver", "sa", "root@123",
sqlParse, null);
mySqlCatalog = new MySqlCatalog("mysql", "root", "root@123",
MysqlUrlInfo);
postgresCatalog = new PostgresCatalog("postgres", "postgres",
"postgres", pg, null);
- mySqlCatalog.open();
- sqlServerCatalog.open();
- postgresCatalog.open();
+ // mySqlCatalog.open();
+ // sqlServerCatalog.open();
+ // postgresCatalog.open();
Review Comment:
Why is it annotated here
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/JdbcUrlUtil.java:
##########
@@ -87,7 +209,19 @@ public Optional<String> getDefaultDatabase() {
}
public String getUrlWithDatabase(String database) {
+ if (isSqlServer) {
+ return urlWithoutDatabase
+ + ";"
+ + String.format("databaseName=%s", database)
+ + suffix;
+ }
return urlWithoutDatabase + "/" + database + suffix;
}
}
+
+ public static void main(String[] args) {
+ String url = "jdbc:sqlserver://sqlserver;encrypt=false;";
+ UrlInfo urlInfo = getUrlInfo(url);
+ System.out.println(urlInfo.getUrlWithDatabase().get());
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
