Copilot commented on code in PR #9273:
URL: https://github.com/apache/seatunnel/pull/9273#discussion_r2076637171
##########
seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/serialize/SeaTunnelRowSerializer.java:
##########
@@ -45,27 +45,45 @@ public class SeaTunnelRowSerializer implements
DorisSerializer {
private final String fieldDelimiter;
private final boolean enableDelete;
private final SerializationSchema serialize;
+ private final boolean caseSensitive;
public SeaTunnelRowSerializer(
String type,
SeaTunnelRowType seaTunnelRowType,
String fieldDelimiter,
boolean enableDelete) {
+ this(type, seaTunnelRowType, fieldDelimiter, enableDelete, true);
+ }
+
+ public SeaTunnelRowSerializer(
+ String type,
+ SeaTunnelRowType seaTunnelRowType,
+ String fieldDelimiter,
+ boolean enableDelete,
+ boolean caseSensitive) {
this.type = type;
this.fieldDelimiter = fieldDelimiter;
this.enableDelete = enableDelete;
- List<Object> fieldNames = new
ArrayList<>(Arrays.asList(seaTunnelRowType.getFieldNames()));
+ this.caseSensitive = caseSensitive;
+
+ String[] fieldNames = seaTunnelRowType.getFieldNames();
Review Comment:
[nitpick] Add a brief comment to explain why we are converting field names
based on the case_sensitive flag to aid future maintainers.
```suggestion
String[] fieldNames = seaTunnelRowType.getFieldNames();
// Normalize field names based on the caseSensitive flag.
// If caseSensitive is false, convert field names to lowercase to
ensure consistent handling
// in case-insensitive environments.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
