Hisoka-X commented on code in PR #9299:
URL: https://github.com/apache/seatunnel/pull/9299#discussion_r2095590096


##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLType.java:
##########
@@ -492,7 +492,21 @@ private SeaTunnelDataType<?> getFunctionType(Function 
function) {
             case ZetaSQLFunction.COALESCE:
             case ZetaSQLFunction.IFNULL:
                 // Result has the same type as first argument
-                return 
getExpressionType(function.getParameters().getExpressions().get(0));
+                if 
(function.getName().equalsIgnoreCase(ZetaSQLFunction.COALESCE)) {

Review Comment:
   Why not just split it into different cases?
   ```
   case ZetaSQLFunction.IFNULL:
       xxx
   case ZetaSQLFunction.COALESCE:
      xxx
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to