hawk9821 commented on code in PR #9671:
URL: https://github.com/apache/seatunnel/pull/9671#discussion_r2276486199
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/split/ClickhouseSourceSplitEnumerator.java:
##########
@@ -121,16 +121,14 @@ public void close() throws IOException {
@Override
public void addSplitsBack(List<ClickhouseSourceSplit> splits, int
subtaskId) {
if (!splits.isEmpty()) {
- synchronized (stateLock) {
- addPendingSplit(splits, subtaskId);
- if (context.registeredReaders().contains(subtaskId)) {
- assignSplit(Collections.singletonList(subtaskId));
- } else {
- LOG.warn(
- "Reader {} is not registered. Pending splits {}
are not assigned.",
- subtaskId,
- splits);
- }
+ addPendingSplit(splits, subtaskId);
Review Comment:
why remove the lock .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
