Hisoka-X commented on PR #9760: URL: https://github.com/apache/seatunnel/pull/9760#issuecomment-3218907951
Hi @joonseolee , thanks for your PR. However, this implementation may require some adjustments before it can be merged. 1. We should add new format in https://github.com/apache/seatunnel/blob/555f6c6096a46c7ad3d9a022b42b0008e6a460e1/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/FileFormat.java#L46 2. We should use file series source to read markdown file and parse it in `MarkdownReadStrategy` added by step 1. So all function in file source connector, not another transform. Please refer https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/MultipleTableFileSourceReader.java#L42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
