dyp12 commented on code in PR #9805:
URL: https://github.com/apache/seatunnel/pull/9805#discussion_r2314214929
##########
docs/en/connector-v2/sink/CosFile.md:
##########
@@ -37,6 +37,9 @@ To use this connector you need put
hadoop-cos-{hadoop.version}-{version}.jar and
- [x] excel
- [x] xml
- [x] binary
+ - [x] canal_json
+ - [x] debezium_json
+ - [x] maxwell_json
Review Comment:
> Have you checked the behavior of `canal_json` and `maxwell_json`? I'm not
sure about it should merge or not.
are you mean merge code ? the behavior of canal_json and maxwell_json
merge in https://github.com/apache/seatunnel/pull/9336, i just add doc, in
https://github.com/apache/seatunnel/pull/9336 only add zh doc
##########
docs/en/connector-v2/sink/CosFile.md:
##########
@@ -37,6 +37,9 @@ To use this connector you need put
hadoop-cos-{hadoop.version}-{version}.jar and
- [x] excel
- [x] xml
- [x] binary
+ - [x] canal_json
+ - [x] debezium_json
+ - [x] maxwell_json
Review Comment:
> Have you checked the behavior of `canal_json` and `maxwell_json`? I'm not
sure about it should merge or not.
are you mean merge code ? the behavior of canal_json and maxwell_json merge
in https://github.com/apache/seatunnel/pull/9336, i just add doc, in
https://github.com/apache/seatunnel/pull/9336 only add zh doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
