liugddx commented on code in PR #9688: URL: https://github.com/apache/seatunnel/pull/9688#discussion_r2352629416
########## seatunnel-api/src/main/java/org/apache/seatunnel/api/metalake/MetalakeConfigUtils.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.api.metalake; + +import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.JsonNode; +import org.apache.seatunnel.shade.com.typesafe.config.Config; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigList; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigObject; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigValue; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigValueFactory; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigValueType; + +import org.apache.seatunnel.common.utils.PlaceholderUtils; + +import lombok.extern.slf4j.Slf4j; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +@Slf4j +public class MetalakeConfigUtils { + + private static final Pattern pattern = Pattern.compile("\\$\\{([^}]*)\\}"); + + public static Config getMetalakeConfig(Config jobConfigTmp) { + Config update = jobConfigTmp; + String metalakeType = System.getenv("METALAKE_TYPE"); + String metalakeUrl = System.getenv("METALAKE_URL"); Review Comment: > Maybe user can overwrite it on job config `env` part is better. cc @liugddx Yes, user can retrieve variables from the environment (env), and if they are not present in the environment, they can obtain them from the System. `Config envConfig = config.getConfig("env");` ########## tools/dependencies/known-dependencies.txt: ########## @@ -9,7 +9,9 @@ disruptor-3.4.4.jar guava-27.0-jre.jar hazelcast-5.1.jar httpclient-4.5.13.jar +httpcore-4.4.13.jar httpcore-4.4.16.jar +httpcore-4.4.4.jar Review Comment: httpcore has been introduced in multiple versions. Can we unify the version? <img width="1798" height="1236" alt="image" src="https://github.com/user-attachments/assets/b647552c-ece5-4888-89e0-59e9674a4797"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
