Hisoka-X commented on code in PR #9942:
URL: https://github.com/apache/seatunnel/pull/9942#discussion_r2431051842
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/InsertOrUpdateBatchStatementExecutor.java:
##########
@@ -121,6 +123,8 @@ public void closeStatements() throws SQLException {
if (!submitted) {
executeBatch();
}
+ } catch (JdbcConnectorException e) {
Review Comment:
Maybe we should catch `JdbcConnectorException` in
https://github.com/apache/seatunnel/blob/f022e409ca1f19ec2bd43ed9a3b2a2154e7e0d47/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java#L205-L213.
To assert the `JdbcConnectorErrorCode` to know we can ignore it or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
