yzeng1618 opened a new pull request, #10145: URL: https://github.com/apache/seatunnel/pull/10145
https://github.com/apache/seatunnel/issues/10137 <!-- Thank you for contributing to SeaTunnel! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! ## Contribution Checklist - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues). - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc. - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`. --> ### Purpose of this pull request <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.--> This pull request fixes several edge‑case bugs in the SQL transform functions (mainly numeric, string and date/time functions) and adds/updates SQL‑level tests such as SQLNumericFunctionsTest, SQLStringFunctionsTest and SQLSystemFunctionsTest to cover them. It also cleans up test comments to remove Chinese characters so that ChineseCharacterCheckTest and the CI checks can pass. ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev. If no, write 'No'. If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544. --> Yes. Some date/time functions (for example month difference and week/day‑of‑week related functions) are corrected to follow the documented and common SQL semantics. Numeric casting and SIGN behavior are adjusted (e.g. support for SHORT type, case‑insensitive type names, and SIGN(NULL) now returning NULL instead of 0). String functions such as ASCII, LEFT and RIGHT now handle NULL, empty strings and negative/zero lengths more consistently (e.g. ASCII(NULL)/ASCII('') return NULL, LEFT/RIGHT with negative length return an empty string and over‑length counts return the whole string). These are all bug fixes to existing SQL behavior; no new configuration or connector‑level behavior is introduced. ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example. --> Added and updated SQL‑level unit tests for numeric, string and system functions, including SQLNumericFunctionsTest, SQLStringFunctionsTest and SQLSystemFunctionsTest. Verified the behavior locally by running module tests such as mvn -pl seatunnel-transforms-v2 -Dtest=SQL*FunctionsTest test and ensuring ChineseCharacterCheckTest passes after removing Chinese comments. ### Check list * [ ] If any new Jar binary package adding in your PR, please add License Notice according [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md) * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs * [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR. * [ ] If you are contributing the connector code, please check that the following files are updated: 1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it 2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml) 3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml) 4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/) 5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
